Files
pmb da4fa18525
CI / Build and Test (gcc, g++, ubuntu-latest) (push) Failing after 5m2s
CI / Code Coverage (push) Skipped
Build and Publish Docker Image / build-and-test (push) Failing after 6m13s
Build and Publish Docker Image / build-and-push-image (push) Skipped
Build and Publish Docker Image / security-scan (push) Skipped
Add FINGER_BAN_ALLOWLIST to exempt trusted front-end IPs from banning
The per-IP ban tracker treats every globally-routable client equally, but an
aggregating front-end like the finger-web proxy funnels the whole internet's
federated lookups through a single IP. A burst from any one client of the proxy
(or a load test) is then attributed to the proxy's IP and, once it crosses the
failure threshold, the daemon blocks the proxy — taking out finger lookups for
everyone. Per-client abuse protection for the proxied path belongs in the proxy
(which now rate-limits per real client IP), so the daemon should trust it.

Add a FINGER_BAN_ALLOWLIST env var (comma-separated IPs). Allowlisted addresses
are marked non-trackable in the listener, so their connections are never blocked
and never recorded as offenses. Unset = unchanged behaviour.

- parse_ip_allowlist() in ban.cpp (trims entries, skips blanks) + unit tests
- listener() consults the set when computing 'trackable'
- documented in docker-compose.yml and DOCKER.md
2026-06-17 10:44:47 -07:00

155 lines
5.8 KiB
C++

#include <iostream>
#include <boost/asio/as_tuple.hpp>
#include <boost/asio/co_spawn.hpp>
#include <boost/asio/deferred.hpp>
#include <boost/asio/detached.hpp>
#include <boost/asio/io_context.hpp>
#include <boost/asio/ip/tcp.hpp>
#include <boost/asio/signal_set.hpp>
#include <boost/asio/steady_timer.hpp>
#include <boost/asio/write.hpp>
#include <chrono>
#include <cstdio>
#include <cstdlib>
#include <string>
#include <unordered_set>
#include "ban.hpp"
#include "handler.hpp"
using boost::asio::awaitable;
using boost::asio::co_spawn;
using boost::asio::deferred;
using boost::asio::detached;
using boost::asio::ip::tcp;
namespace this_coro = boost::asio::this_coro;
awaitable<std::string> dofinger(const std::string &username) {
co_return process(username);
}
awaitable<void> echo(tcp::socket socket, std::string client_addr, bool trackable,
BanTracker &bans) {
try {
auto now = std::chrono::steady_clock::now();
// An IP that has racked up too many failed lookups (scanners, username
// guessers, non-finger junk) is dropped without being read or answered.
// Only globally-routable addresses are tracked: behind Docker's bridge
// every client is SNAT'd to the gateway, so banning there would block
// everyone at once (see is_bannable_address()).
if (trackable && bans.is_blocked(client_addr, now)) {
std::printf("finger drop from %s: blocked\n", client_addr.c_str());
co_return;
}
char data[1024];
auto [read_ec, bytes_read] = co_await socket.async_read_some(
boost::asio::buffer(data), boost::asio::as_tuple(deferred));
if (read_ec) {
// Client hung up before sending a request: health checks (which connect
// and immediately close), port scanners, and reset connections all land
// here. This is normal -- don't log it as an exception.
co_return;
}
std::string username(data, bytes_read);
// Remove trailing \r\n characters
while (!username.empty() &&
(username.back() == '\r' || username.back() == '\n')) {
username.pop_back();
}
std::printf("finger request from %s for user '%s'\n",
client_addr.c_str(), username.c_str());
auto response = co_await dofinger(username);
// A "failure" is simply any request that does not resolve to a readable
// plan file: an unknown user, rejected input, or non-finger junk. Each
// failure is timestamped against the client IP; once an IP exceeds the
// threshold within the rolling window, the is_blocked() check above starts
// dropping its connections. This also frustrates username guessing.
bool plan_served =
response != username && response.rfind("InvalidInput:", 0) != 0;
if (!plan_served) {
if (trackable) {
auto res = bans.record_offense(client_addr, now);
std::printf("finger miss from %s for '%s' (%d failures in window)%s\n",
client_addr.c_str(), username.c_str(), res.count,
res.blocked ? " -- now blocked" : "");
} else {
std::printf("finger miss from %s for '%s' (not tracked)\n",
client_addr.c_str(), username.c_str());
}
// Best-effort reply; ignore write errors (the client may have already
// gone away).
co_await async_write(socket,
boost::asio::buffer(std::string("No plan found\r\n")),
boost::asio::as_tuple(deferred));
co_return;
}
co_await async_write(socket, boost::asio::buffer(response),
boost::asio::as_tuple(deferred));
co_return;
} catch (std::exception &e) {
std::printf("echo exception: %s\n", e.what());
}
}
awaitable<void> listener(BanTracker &bans,
const std::unordered_set<std::string> &allowlist) {
auto executor = co_await this_coro::executor;
tcp::acceptor acceptor(executor, {tcp::v4(), 79});
for (;;) {
tcp::socket socket = co_await acceptor.async_accept(deferred);
boost::system::error_code ec;
auto endpoint = socket.remote_endpoint(ec);
std::string client_addr =
ec ? std::string("unknown") : endpoint.address().to_string();
// Allowlisted IPs (trusted aggregating front-ends like the finger-web
// proxy) are never tracked, so their bursts neither block them nor count
// as offenses.
bool trackable = !ec && is_bannable_address(endpoint.address()) &&
allowlist.find(client_addr) == allowlist.end();
co_spawn(executor,
echo(std::move(socket), std::move(client_addr), trackable, bans),
detached);
}
}
// Periodically prune offense records that have aged out of the window so the
// tracker's memory stays bounded even for IPs that never reconnect.
awaitable<void> sweeper(BanTracker &bans) {
boost::asio::steady_timer timer(co_await this_coro::executor);
for (;;) {
timer.expires_after(std::chrono::minutes(10));
co_await timer.async_wait(deferred);
bans.sweep(std::chrono::steady_clock::now());
}
}
int main() {
// Line-buffer stdout so docker logs / tail -f see entries in real time.
std::setvbuf(stdout, nullptr, _IOLBF, 0);
try {
boost::asio::io_context io_context(1);
BanTracker bans;
const char *allow_env = std::getenv("FINGER_BAN_ALLOWLIST");
const std::unordered_set<std::string> allowlist =
parse_ip_allowlist(allow_env ? allow_env : "");
for (const auto &ip : allowlist) {
std::printf("ban allowlist: %s (never tracked or blocked)\n", ip.c_str());
}
boost::asio::signal_set signals(io_context, SIGINT, SIGTERM);
signals.async_wait([&](auto, auto) { io_context.stop(); });
co_spawn(io_context, listener(bans, allowlist), detached);
co_spawn(io_context, sweeper(bans), detached);
io_context.run();
} catch (std::exception &e) {
std::printf("fatal exception: %s\n", e.what());
}
}